From fb76299d72c50da921f111d1fc3da765a761fbd6 Mon Sep 17 00:00:00 2001 From: Callum Vidler <callum.vidler@hotmail.com> Date: Sun, 2 Sep 2018 20:20:06 +1000 Subject: [PATCH] final --- TEST-swen90006.machine.BoundaryTests.txt | 34 +++++++------------ TEST-swen90006.machine.PartitioningTests.txt | 18 +++++----- classes/swen90006/machine/Machine.class | Bin 4302 -> 4300 bytes src/swen90006/machine/Machine.java | 2 +- 4 files changed, 22 insertions(+), 32 deletions(-) diff --git a/TEST-swen90006.machine.BoundaryTests.txt b/TEST-swen90006.machine.BoundaryTests.txt index c340653..37e7451 100644 --- a/TEST-swen90006.machine.BoundaryTests.txt +++ b/TEST-swen90006.machine.BoundaryTests.txt @@ -1,31 +1,21 @@ Testsuite: swen90006.machine.BoundaryTests -Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.35 sec +Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.37 sec -Testcase: JmpNeg took 0.004 sec +Testcase: JmpNeg took 0.006 sec Testcase: JzLast took 0.001 sec Testcase: JzPast took 0.001 sec -Testcase: RiHigh took 0.001 sec +Testcase: RiHigh took 0 sec Testcase: StrNeg took 0.001 sec -Testcase: valueLow took 0.001 sec -Testcase: valueHigh took 0.001 sec -Testcase: StrHigh took 0.001 sec -Testcase: Div took 0.002 sec - Caused an ERROR -/ by zero -java.lang.ArithmeticException: / by zero - at swen90006.machine.Machine.do_div(Unknown Source) - at swen90006.machine.Machine.execute(Unknown Source) - at swen90006.machine.BoundaryTests.Div(Unknown Source) - at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) - at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) - at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) - -Testcase: JzNeg took 0.001 sec -Testcase: RiNeg took 0.001 sec -Testcase: Valid took 0.004 sec +Testcase: valueLow took 0 sec +Testcase: valueHigh took 0 sec +Testcase: StrHigh took 0 sec +Testcase: Div took 0 sec +Testcase: JzNeg took 0 sec +Testcase: RiNeg took 0 sec +Testcase: Valid took 0.006 sec Testcase: JmpLast took 0.001 sec Testcase: JmpPast took 0.001 sec Testcase: JzFirst took 0.001 sec Testcase: NoReturn took 0.002 sec -Testcase: RiValueHigh took 0.002 sec -Testcase: JmpFirst took 0.289 sec +Testcase: RiValueHigh took 0.001 sec +Testcase: JmpFirst took 0.319 sec diff --git a/TEST-swen90006.machine.PartitioningTests.txt b/TEST-swen90006.machine.PartitioningTests.txt index a63c54d..e4d3135 100644 --- a/TEST-swen90006.machine.PartitioningTests.txt +++ b/TEST-swen90006.machine.PartitioningTests.txt @@ -1,17 +1,17 @@ Testsuite: swen90006.machine.PartitioningTests -Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.068 sec +Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.057 sec -Testcase: JmpNeg took 0.009 sec -Testcase: strHigh took 0.006 sec -Testcase: RiHigh took 0.001 sec +Testcase: JmpNeg took 0.006 sec +Testcase: strHigh took 0.005 sec +Testcase: RiHigh took 0.002 sec Testcase: ValueLow took 0.001 sec -Testcase: jzHigh took 0.005 sec -Testcase: strNeg took 0.002 sec +Testcase: jzHigh took 0.006 sec +Testcase: strNeg took 0.001 sec Testcase: Div took 0 sec Testcase: RiNeg took 0.001 sec Testcase: Valid took 0.004 sec -Testcase: jzNeg took 0.003 sec +Testcase: jzNeg took 0.002 sec Testcase: JmpHigh took 0.002 sec -Testcase: NoReturn took 0 sec +Testcase: NoReturn took 0.001 sec Testcase: RiMaxValue took 0.001 sec -Testcase: ValueHigh took 0 sec +Testcase: ValueHigh took 0.001 sec diff --git a/classes/swen90006/machine/Machine.class b/classes/swen90006/machine/Machine.class index 7016ffa225790cdf3bdffe9762ca3de4168e1569..0ab5b48bb6e548887f83b0df028a29bc8694c4c8 100644 GIT binary patch delta 35 rcmX@7ct&wU5to1&11kdy0|SGC))odfS-n}4Tewsic{Z=&QeguCo7V^> delta 37 tcmX@3cusLc5ton!11kdy0|SGS))odfSv`T21(Tb&R2lg;ui#Q)0|2Y-2%`W1 diff --git a/src/swen90006/machine/Machine.java b/src/swen90006/machine/Machine.java index 61c7bf8..c437923 100644 --- a/src/swen90006/machine/Machine.java +++ b/src/swen90006/machine/Machine.java @@ -73,7 +73,7 @@ public class Machine private void do_div(int dest, int src1, int src2) { - if (regs[src2] == 100){ + if (regs[src2] == 0){ /* no op */ }else{ regs[dest] = regs[src1] / regs[src2]; -- GitLab